I virtually never write these, so I'll try to make it good, haha!
I think the prices for Sanctuary rental properties should be reassessed and lowered, honestly!
The House of Trade storage seems to be pretty well-priced for me, but I feel like the amount of gold required for some of the other options is so high that it prevents some really great player groups from renting the High House/Temple/Warehouse/Barracks.
It's a great automated system, but the high price tag, while admittedly adding to verisimilitude, seems to be too high a barrier for all but the most dedicated gold-earners. I don't think having lots of gold and being an interesting group of PCs is mutually exclusive, but the combination is definitely rarer than one or the other!
From a story standpoint, Sanctuary would probably rather see these properties rented out than remain empty too, which many of them appear to have been for some time!
Cheaper properties, yes. They should also have some sort of scripted perk as well. Like, the Warehouse gives 2gp a tick for key owners when inside the warehouse, High House grants +1 charisma for resting there, Barracks grant +3 discipline or something.